feat: add pre-commit and update readme #100
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bbelderbos
reviewed
Oct 10, 2024
|
@niltonpimentel02 the hacktoberfest tag on the repo is enough for this to count for you, right? |
|
Do we need to fix the pre-commit version? https://github.com/PyBites-Open-Source/pybitesbooks/actions/runs/11570097551/job/32205164381 |
we need at least Python 3.9 (that's the version that I'm running locally) on your GitHub actions the version is 3.8 so we need to upgrade it 😄 |
|
OK thanks, I can do that but as you're already going to work on uv, maybe you want to do that there? 🙏 |
sure... no problem! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hey, @bbelderbos this is related to issue #77 I didn't ask to work on it but I worked anyway 🤣 tell me if you find it interesting to merge or if I need to change something.
close #77